drivers: sensor: Add LPC internal temperature sensor #90418
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Sensors
github-actions
bot
requested review from
asemjonovs,
avisconti,
dbaluta,
decsny,
DerekSnell,
dleach02,
jeppenodgaard,
manuargue,
MaureenHelm,
mmahadevan108,
Raymond0225,
teburd,
tristan-google,
ubieda and
yperess
wilkinsw
force-pushed
the
feature/nxp-lpc-temp
branch
3 times, most recently
from
f41dec2 to
0b06d2e
Compare
The LPC ADC has a dedicated input channel for an on-chip temperature sensor. This commit adds support for defining and reading from that channel. Signed-off-by: Wilkins White <ww@novadynamics.com>
wilkinsw
force-pushed
the
feature/nxp-lpc-temp
branch
from
0b06d2e to
c5ee8a6
Compare
wilkinsw
force-pushed
the
feature/nxp-lpc-temp
branch
from
c5ee8a6 to
d31bd1d
Compare
|
Fixed duplicated tag |
wilkinsw
force-pushed
the
feature/nxp-lpc-temp
branch
from
d31bd1d to
8ca843f
Compare
|
Fix line length and bracket failures |
wilkinsw
force-pushed
the
feature/nxp-lpc-temp
branch
from
8ca843f to
29898fc
Compare
|
Fixed blank line at end of yaml file |
wilkinsw
force-pushed
the
feature/nxp-lpc-temp
branch
from
29898fc to
0b4d31c
Compare
|
Fix C99 style comment |
The LPC ADC has a dedicated input channel for an on-chip temperature sensor. This commit adds a sensor driver for reading the die temperature. Signed-off-by: Wilkins White <ww@novadynamics.com>
This commit adds adc0 for the NXP LPC55S1x SoC. Signed-off-by: Wilkins White <ww@novadynamics.com>
This commit adds overlays for the lpcxpresso55s16 to read die temperature from the dedicated ADC channel. Signed-off-by: Wilkins White <ww@novadynamics.com>
wilkinsw
force-pushed
the
feature/nxp-lpc-temp
branch
from
0b4d31c to
344ec83
Compare
|
Fixed the bracket again, and I installed the pre-commit git hook so fingers crossed... |
|
yperess
requested changes
Jun 4, 2025
| @@ -225,6 +225,16 @@ static int mcux_lpadc_channel_setup(const struct device *dev, | |||
| } | |||
| } else if (channel_cfg->reference == ADC_REF_EXTERNAL0) { | |||
| LOG_DBG("ref external0"); | |||
| # if defined(FSL_FEATURE_LPADC_HAS_INTERNAL_TEMP_SENSOR) | |||
| } else if (channel_cfg->reference == ADC_REF_INTERNAL) { | |||
There was a problem hiding this comment.
nit: use IS_ENABLED(FSL_FEATURE_LPADC_HAS_INTERNAL_TEMP_SENSOR) instead of #if
| #include <zephyr/drivers/adc.h> | ||
|
|
||
| #include <zephyr/logging/log.h> | ||
| LOG_MODULE_REGISTER(temp_lpc, CONFIG_SENSOR_LOG_LEVEL); |
There was a problem hiding this comment.
Does clang-format not sort all the includes? Why is the LOG_MODULE_REGISTER needed to be between the includes?
|
|
||
| #include <fsl_lpadc.h> | ||
|
|
||
| BUILD_ASSERT(DT_NUM_INST_STATUS_OKAY(DT_DRV_COMPAT) <= 1, |
There was a problem hiding this comment.
You already filtered building this file in CMake, shouldn't this be == 1?
|
Closing due to #90381 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LPC ADC has a dedicated input channel for an on-chip temperature sensor. This pull request does the following:
This was developed and tested on an LPC5516, but it should work on the other SoCs in the LPC family as well as other chips that use the LPADC such as the RT6XX series.